Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a type parser for TypedArrayBuilder #668

Merged
merged 23 commits into from
Feb 28, 2021
Merged

Write a type parser for TypedArrayBuilder #668

merged 23 commits into from
Feb 28, 2021

Conversation

reikdas
Copy link
Collaborator

@reikdas reikdas commented Jan 25, 2021

No description provided.

@jpivarski
Copy link
Member

This is good; doing it in studies for now.

@reikdas reikdas force-pushed the reikdas/type-parser branch 2 times, most recently from 85949c1 to ba33ce1 Compare February 12, 2021 07:49
jpivarski
jpivarski reviewed Feb 12, 2021
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it out and tried some examples. Some of these didn't work, so I labeled them as pytest.mark.skip, but that makes them visible when you run

pytest -vv -rs parser.py

At least check to see how difficult it would be to add these. (I want to be sure that the structure of the parser will accommodate them.) Thanks!

@reikdas
Copy link
Collaborator Author

reikdas commented Feb 27, 2021

@jpivarski All the tests you added pass now. Should we merge this into studies/ now and then create a separate PR where we integrate it into the main codebase?

@jpivarski
Copy link
Member

@jpivarski All the tests you added pass now. Should we merge this into studies/ now and then create a separate PR where we integrate it into the main codebase?

Yes! You can merge it whenever you're ready.

@reikdas reikdas marked this pull request as ready for review February 28, 2021 05:44
@reikdas reikdas enabled auto-merge (squash) February 28, 2021 05:47
reikdas and others added 18 commits February 28, 2021 20:29
@reikdas
Write a type parser for future TypedArrayBuilder
92bda08
@reikdas
Avoid using Python keywords in Grammar
ee2a4bb
@reikdas
UnknownType can have parameters
68487d2
@reikdas
Use datashape regex for string
aabd0dd
@reikdas
Fix parser to prepare for RecordType
b1f7d43
@reikdas
We don't need intermediate object
3905458
@reikdas
Able to parse basic Record Types
5cbded3
@reikdas
Cleanup parser implementation
bfad424 
Use pytest instead of a sequence of commands to test if working.
Can now parse RecordTypes with infinitely long tuples
@reikdas
Parse all RecordType types
d429163
@reikdas
Add OptionType parser
4b447ac
@reikdas
Parse RegularTypes
97c1568
@reikdas
Parse ListTypes and UnionTypes
ab64bb9
@jpivarski @reikdas
A bunch of tests, most of which pass.
20c369c
@reikdas
Parse hardcoded typestrs
398661c
@reikdas
Begin handling ArrayTypes
7e5d3e6
@reikdas
Handle byte and bytestring
6be3a7e
@reikdas
Handle ArrayTypes built of RecordTypes
4dc9fda
@reikdas
Handle high level option type lists
c65fbc5
@reikdas reikdas merged commit 2832a85 into main Feb 28, 2021
@reikdas reikdas deleted the reikdas/type-parser branch February 28, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski Awaiting requested review from jpivarski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reikdas @jpivarski