Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cython from install requires #624

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Feb 6, 2024

Cython is a build-only dependency, so this PR removes Cython from the install_requires list of the hdbscan package.

setup.py reads requirements.txt to populate its runtime requirements, and requirements.txt incldues cython. So removing it from requirements.txt should be sufficient to fix this.

I can make a separate requirements-build.txt if the maintainers prefer using a requirements file for build dependencies.

Copy link

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul! 🙏

Had a question below

requirements.txt Show resolved Hide resolved
@jakirkham
Copy link

jakirkham commented Jul 22, 2024

Should we change this to build with Cython 3+ and NumPy 2+ as well?

[build-system]
requires = [
"setuptools",
"wheel",
"cython<4",
"numpy<3"
]

So...

 [build-system]
 requires = [
   "setuptools",
   "wheel",
-  "cython<4",
+  "cython>=3,<4",
-  "numpy<3"
+  "numpy>=2,<3"
 ]

@lmcinnes
Copy link
Collaborator

lmcinnes commented Aug 5, 2024

Thank you!

@lmcinnes lmcinnes merged commit f98aefa into scikit-learn-contrib:master Aug 5, 2024
1 check passed
@jakirkham
Copy link

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants