Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

64bit support #10

Closed
biddster opened this issue Feb 29, 2016 · 5 comments
Closed

64bit support #10

biddster opened this issue Feb 29, 2016 · 5 comments

Comments

@biddster
Copy link
Contributor

Using rootbeer on a 64bit device (Nexus 6P) and I get an exception saying the native library is missing.

I'll look to provide a PR with a fix.
@biddster
Copy link
Contributor Author

Can't see for looking, 64bit libs are in there. I'll try harder and try to get to the bottom of it. It's working on everything other than my 6P.

@biddster
Copy link
Contributor Author

biddster commented Mar 7, 2016

Ah, got it, rootbeerlib/jni/build.sh doesn't copy the 64bit libs into the source tree. Consequently, the native libs don't make it into the aar.

@scottyab
Copy link
Owner

scottyab commented Mar 7, 2016

good spot

@biddster
Copy link
Contributor Author

biddster commented Mar 7, 2016

I'll throw you a PR for a fix.

@biddster biddster mentioned this issue Mar 7, 2016
Merged
stealthcopter added a commit that referenced this issue Mar 14, 2016
@stealthcopter
Merge pull request #12 from biddster/master
2d62e95 
Fix for issue #10, missing jni libs in aar
@scottyab
Copy link
Owner

Thanks @biddster 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottyab @biddster