Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation seems to be broken on python3.6.4 #488

Closed
jackton1 opened this issue Feb 26, 2020 · 5 comments · Fixed by #489
Closed

Installation seems to be broken on python3.6.4 #488

jackton1 opened this issue Feb 26, 2020 · 5 comments · Fixed by #489

Comments

@jackton1
Copy link

Screen Shot 2020-02-26 at 12 31 00 PM

@adamchainz
Copy link
Contributor

Hi @jackton1 !

Thanks for the report.

I think you're compiling with quite an old macOS / X Code / clang there. It does look however like we're using the non-standard C __thread keyword. Let me look into this and come back to you!

Thanks,

Adam

@jackton1
Copy link
Author

This seems to be linked to using

/Library/Frameworks/Python.framework/Versions/3.6/bin/python3.6 if that helps switch to pyenv which seems to work fine.

@adamchainz
Copy link
Contributor

I've done a bit more research. It won't help to switch pyenv. The best thing to do is upgrade your macOS, or if you can't do that, at least your C compiler clang. It turns out __thread is standard.

I'm also going to look into a way for Scout to install itself without the C extension if it won't compile. But I can't say when that will be done.

Thanks,

Adam

@jackton1
Copy link
Author

Already tested using pyenv's python 3.6.4 and didn't have any issues.

Upgrading Mac didn't seem to help it was still pointing to the same path.

$ sw_vers 
ProductName:    Mac OS X
ProductVersion: 10.15.3
BuildVersion:   19D76

@jackton1 jackton1 changed the title Installation seems to be broken on pythoon3.6.4 Installation seems to be broken on python3.6.4 Feb 28, 2020
@adamchainz
Copy link
Contributor

How did you install Python 3.6.4 previously?

adamchainz added a commit that referenced this issue Mar 2, 2020
Fixes #488.

I tested this by deliberately introducing a syntax error into `_objtrace.c`. Without `optional=True`, installation in a virtual environment failed; with it, it passes, and without any error message.
adamchainz added a commit that referenced this issue Mar 2, 2020
Fixes #488.

I tested this by deliberately introducing a syntax error into `_objtrace.c`. Without `optional=True`, installation in a virtual environment failed; with it, it passes, and without any error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants