-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve debug level logging #654
Comments
@jrothrock how does this collection of data sound? [
("start_time", self.start_time),
("end_time", self.end_time),
("duration", (self.end_time - self.start_time).total_seconds()),
("active_spans", len(self.active_spans)),
("complete_spans", len(self.complete_spans)),
("tags", len(self.tags)),
("hit_max", self.hit_max),
("is_real_request", self.is_real_request),
] |
tim-schilling
added a commit
that referenced
this issue
Jun 17, 2021
It now contains summary information for the request that is logged after the request has been sent. Closes #654
@tim-schilling Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently don't capture a lot of useful information when logging is set to debug. This can make identifying support issues tough
The configuration that we collect at the top of the log is very useful, but once we get to actually recording the requests, we don't have much visibility. As seen at the bottom of the logs, all we say is when a request starts and ends, and we are missing some valuable information like what time the request started and ended, as well as some of the payload/request information (total duration, maybe complete_spans count?)
For example, here's a script of what debug logs looks like:
The text was updated successfully, but these errors were encountered: