-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Starlette integration #349
Conversation
try: | ||
from asgiref.local import Local | ||
except ImportError: | ||
from threading import local as Local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if they are not running Python 3.5+ with asgiref, we fall back to using Treading.local, which will not support async tracking, correct?
I wonder if we should log a line that syas something to that effect: Async tracking unavailable (Requires Python 3.5+)
or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only in Python 3.5 that the async functionality was added to Python so that wouldn't really add any information :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I had thought Python had async for longer. Nevermind, then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's been gevent and other styles of async for a while - in general it's a confusing landscape. Still need to get around to official gevent support in #28.
Document the integration added in scoutapp/scout_apm_python#349 .
* Document Starlette integration Document the integration added in scoutapp/scout_apm_python#349 .
Fixes #233 .
Basic Starlette integration that tracks HTTP only. Websocket implementation would be a bit more fun.