Skip to content

Commit

Permalink
Merge pull request #9652 from scratchfoundation/taller-screen-for-tests
Browse files Browse the repository at this point in the history
test: boost screen height to fix l10n test
  • Loading branch information
cwillisf committed Aug 28, 2024
2 parents 43cd8f2 + 9d851ca commit 256b84b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test/helpers/selenium-helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,13 @@ class SeleniumHelper {
const outerError = new Error(`loadUri failed with arguments:\n\turi: ${uri}`);
try {
await this.setTitle(`loadUri ${uri}`);
// TODO: The height is set artificially high to fix this test:
// 'Loading with locale shows correct translation for string length block parameter'
// which fails because the block is offscreen.
// We should set this back to 1024x768 once we find a good way to fix that test.
// Using `scrollIntoView` didn't seem to do the trick.
const WINDOW_WIDTH = 1024;
const WINDOW_HEIGHT = 768;
const WINDOW_HEIGHT = 960;
await this.driver
.get(`file://${uri}`);
await this.driver
Expand Down

0 comments on commit 256b84b

Please sign in to comment.