Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor onLoadedProject() creator to handle success==false consistently; add tests of project state action creators #5362

Merged
merged 5 commits into from
Mar 18, 2020
Merged

refactor onLoadedProject() creator to handle success==false consistently; add tests of project state action creators #5362

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
461877b
project state loading should error if can’t load default
benjiwheeler Jan 6, 2020
50265fe
added tests for project loading states
benjiwheeler Jan 6, 2020
a4e2711
fixed typo
benjiwheeler Jan 6, 2020
3a8fe3f
reorganized switch and conditionals to be clearer; clarified test names
benjiwheeler Jan 27, 2020
2e11787
test resulting projectId; add comments; fix params
benjiwheeler Feb 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed typo
  • Loading branch information
@benjiwheeler
benjiwheeler committed Jan 6, 2020
commit a4e27112abd1436db50382c446f417f3cb16213f
2 changes: 1 addition & 1 deletion test/unit/util/project-saver-hoc.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('projectSaverHOC', () => {
expect(mockedUpdateProject).toHaveBeenCalled();
});

test('if canSave is alreatdy true and we show a project with an id, project will NOT be saved', () => {
test('if canSave is already true and we show a project with an id, project will NOT be saved', () => {
const mockedSaveProject = jest.fn();
const Component = () => <div />;
const WrappedComponent = projectSaverHOC(Component);
Expand Down