Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add pipelineName, jobName, prNum, and template info to pod labels [2] #188

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

tkyi
Copy link
Member

@tkyi tkyi commented Oct 26, 2023

Context

Pods might need more information.

Objective

This PR adds pipelineName, jobName, prNum, and template info to pod labels.

References

Blocked by screwdriver-cd/models#592

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@DekusDenial
Copy link
Contributor

DekusDenial commented Oct 26, 2023

Where is the part adding these values to labels?
I added 184b90a
but you might still need to modify the tests

@klu909
Copy link
Contributor

klu909 commented Oct 26, 2023

might want to change dataschema as well

@tkyi
Copy link
Member Author

tkyi commented Oct 26, 2023

@klu909 Opened screwdriver-cd/data-schema#536

@tkyi tkyi merged commit 0250088 into master Oct 26, 2023
2 checks passed
@tkyi tkyi deleted the podLabels branch October 26, 2023 21:58
@sd-buildbot
Copy link

🎉 This PR is included in version 15.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants