Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make launcher docker file multi-arch compatible #438

Merged
merged 11 commits into from
Apr 29, 2022

Conversation

pritamstyz4ever
Copy link
Contributor

Context

Screwdriver needs to support arm64 containers for building

Objective

This PR updates dockerfile to be multi-arch compatible

References

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Copy link
Contributor

@DekusDenial DekusDenial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can approve this for now, but u need to be aware that there are some binaries here aren’t compatible with arm yet and build dependency on hab is still a pending problem, so there should other follow up to address them

@pritamstyz4ever
Copy link
Contributor Author

i can approve this for now, but u need to be aware that there are some binaries here aren’t compatible with arm yet and build dependency on hab is still a pending problem, so there should other follow up to address them

I agree this will need revision based on version updates and new binaries. Thanks

@pritamstyz4ever pritamstyz4ever merged commit b111303 into master Apr 29, 2022
@pritamstyz4ever pritamstyz4ever deleted the feat/support-arm64 branch April 29, 2022 14:45
@adong adong mentioned this pull request Mar 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants