Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure right event dumping #466

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: ensure right event dumping #466

merged 2 commits into from
Nov 9, 2023

Conversation

DekusDenial
Copy link
Contributor

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

dump_event() {
if [ -r /tmp/sd_event.json ]; then
if [ -r /tmp/sd_event.json ] && [ -z "$event_dumped" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, does event_dumped set elsewhere? Otherwise, how does this ever get called?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's set up above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, it means dump_event only gets called 1 time

@DekusDenial DekusDenial merged commit fcdaeeb into master Nov 9, 2023
1 check passed
@DekusDenial DekusDenial deleted the DekusDenial-patch-1 branch November 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants