feat(2911): Support pipeline metrics in templateFactory #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithine
reviewed
Jul 31, 2023
tkyi
reviewed
Aug 1, 2023
nathom
changed the title
sagar1312
requested changes
Aug 17, 2023
sagar1312
requested changes
Aug 17, 2023
sagar1312
requested changes
Aug 18, 2023
lib/templateFactory.js
Outdated
Comment on lines
275
to
278
| const metricPipelinesConfig = { | ||
| params: { templateId: templateIds }, | ||
| readOnly: true | ||
| }; |
There was a problem hiding this comment.
This is not an optimal solution. This approach loads the all the fields of job objects from the DB to memory and perform aggregation here.
As we had discussed, we should enhance datastore-sequelize to accept input and generate below SQL query so that the aggregation is performed at source (DB)
select count(distinct(pipelineId)), templateId
from jobs
group by templateId;
sagar1312
requested changes
Aug 22, 2023
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
sagar1312
reviewed
Aug 30, 2023
sagar1312
requested changes
Aug 31, 2023
Remove comment Add filter Fix filter Update lib/templateFactory.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update test/lib/templateFactory.test.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update test/lib/templateFactory.test.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update lib/templateFactory.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update lib/templateFactory.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update lib/templateFactory.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update lib/templateFactory.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Improve test data Update lib/templateFactory.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update lib/templateFactory.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Update test/lib/templateFactory.test.js Co-authored-by: Dayanand Sagar <sagar1312@gmail.com> Fix pipelineUsage tests Remove unnecessary mocks Add test Verify calls Remove only
sagar1312
approved these changes
Aug 31, 2023
|
🎉 This PR is included in version 29.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It has been requested that template maintainers are able to see who is using which version, so that once
a new version has been released, those using an old version can be notified.
Objective
Show the Pipelines that use a template version.
References
screwdriver-cd/screwdriver#2911
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.