Merge pull request #54 from screwdriver-cd/adding-pr

fix: decorate pr
screwdriver-cd · May 8, 2018 · b2b6777 · b2b6777
2 parents 45eb170 + d52945e
commit b2b6777
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -347,10 +347,10 @@ The parameters required are:
 | config.scmContext | String | No | The name of scm context |
 
 #### Expected Outcome
-The object consists of PR name, sha and ref for the pipeline.
+The object consists of PR name, sha, ref, and url for the pipeline.
 
 #### Expected Promise Response
-1. Resolve with the object consists of PR name, sha and ref
+1. Resolve with the object consists of PR name, sha, ref, and url
 2. Reject if the input or output is not valid
 
 ### getScmContexts

diff --git a/index.js b/index.js
@@ -358,7 +358,8 @@ class ScmBase {
             .then(pr => validate(pr, Joi.object().keys({
                 name: Joi.reach(dataSchema.models.job.base, 'name').required(),
                 sha: Joi.reach(dataSchema.models.build.base, 'sha').required(),
-                ref: Joi.string().required()
+                ref: Joi.string().required(),
+                url: Joi.reach(dataSchema.core.scm.pr, 'url')
             })));
     }