fix(1961): Response does not need to be JSON parsed (#80)

screwdriver-cd · Sep 7, 2021 · d61b302 · d61b302
1 parent 2dd1fc7
commit d61b302
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -1037,9 +1037,7 @@ class BitbucketScm extends Scm {
         }
 
         const response = await this.breaker.runCommand(params);
-
-        // we will have to parse the body since we are sending a normal FORM POST request
-        const body = JSON.parse(response.body);
+        const { body } = response;
 
         if (response.statusCode !== 200) {
             throw new Error(`STATUS CODE ${response.statusCode}: ${JSON.stringify(body)}`);

diff --git a/test/index.test.js b/test/index.test.js
@@ -2213,7 +2213,7 @@ describe('index', function() {
         beforeEach(() => {
             const response = {
                 statusCode: 200,
-                body: JSON.stringify(testPayloadAccessToken)
+                body: testPayloadAccessToken
             };
 
             requestMock.resolves(response);