Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Send slack notifications to multi workspace. #2505

Closed
kumada626 opened this issue Jul 8, 2021 · 1 comment
Closed

[Feature Request] Send slack notifications to multi workspace. #2505

kumada626 opened this issue Jul 8, 2021 · 1 comment
Labels

Comments

@kumada626
Copy link
Contributor

What you expected to happen:
Currently, Screwdriver can send slack notification to only single slack workspace.
It is nice that users can receive slack notification on multi workspace.
For example, one job notifies channel A in workspace B, another job notifies channel C in workspace D.

@tkyi tkyi added the feature label Jul 8, 2021
@ibu1224
Copy link
Contributor

ibu1224 commented Aug 8, 2023

@jithine @kumada626 cc: @screwdriver-cd/admin-all

[Breaking Change]
This design is partially backward incompatible.
Please comment if you have any concerns.

YJ has started to work on this issue.

How users specify their workspace

settings:
  slack:
    channels:
      - workspace1:notice
      - workspace2:notice
      - notice

Set workspace name and channel name with ":".
If no workspace is specified, the workspace set by default, described below, is used as the notification settings.
Users have backward compatibility.

I am all about transitionality.
The use of ":" requires a small learning cost to set up. However, there is documentation in Screwdriver.cd, so it is sufficient if it is described there.

Modifications to be Made by the Administrator

  1. Enable to place a slack bot token for each workspace
[Breaking Change]
notifications:
  options:
    # Throw error when validation fails (default true); otherwise show warning
    throwValidationErr: true
   slack:
      defaultWorkspace: workspace1
      workspaces:
        - name: workspace1
           token: your-slack-bot-token
        - name: workspace2
           token: your-slack-bot-token

This configuration method is not backward compatible.
Cluster administrators must follow the new configuration method. Until then, no slack notifications will be made.

defaultWorkspace means the workspace to be notified if workspace is not specified.

  1. Modification of notification-slack
    Please confirm details at the time of revision. The following is a list of objects to be corrected.
  • Modification of joi.schema to read changed settings
  • Added new method to switch notification destinations
  • Added the ability to use multiple tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants