Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2] feat(2505): multi workspace slack notification setting #2913

Merged

Conversation

y-oksaku
Copy link
Contributor

@y-oksaku y-oksaku commented Aug 10, 2023

Context

BREAKING CHANGE: Slack notification config is changed. It must be changed to the new configuration format.

This PR is the implementation of this.
#2505 (comment)

Objective

Change the example of slack notification setting to the new format.

References

Issues

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

BREAKING CHANGE: slack notification config is changed
It must be changed to the new configuration format.
@coveralls
Copy link

coveralls commented Aug 10, 2023

Coverage Status

coverage: 95.296%. remained the same when pulling a76f130 on sonic-screwdriver-cd:feat-slack-multi-workspace into ad30427 on screwdriver-cd:master.

tkyi
tkyi previously approved these changes Aug 10, 2023
@y-oksaku y-oksaku changed the title [1] feat(2505): multi workspace slack notification setting [2] feat(2505): multi workspace slack notification setting Aug 10, 2023
@y-oksaku
Copy link
Contributor Author

I will bump major version notifications-slack.
Please review tihs PR after release new version notifications-slack.

tkyi
tkyi previously approved these changes Aug 11, 2023
@tkyi tkyi merged commit 8c199b0 into screwdriver-cd:master Aug 15, 2023
@y-oksaku y-oksaku deleted the feat-slack-multi-workspace branch August 15, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants