Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows special characters to be used in branches #2952

Closed
yakanechi opened this issue Nov 14, 2023 · 2 comments
Closed

Allows special characters to be used in branches #2952

yakanechi opened this issue Nov 14, 2023 · 2 comments

Comments

@yakanechi
Copy link
Contributor

yakanechi commented Nov 14, 2023

What happened:
On GitHub, it was possible to use full-width space of Japanese in branch names, but these characters were not available in SD.

What you expected to happen:
Allows pipelines to be created and built with branch names that contain special characters and full-width space of Japanese.

How to reproduce it:
Work in the following sequence.

  1. fix(2952): Make special characters available in branch names [1] data-schema#542
  2. fix(2952): Fix test of special characters [2] data-schema#543
  3. fix(2952): Make special characters available in branch name [3] scm-github#218
  4. fix(2952): Make full-width space available in branch name [4] ui#963
@yakanechi
Copy link
Contributor Author

yakanechi commented Nov 14, 2023

Known Issue

These changes allow rootDirs with paths containing special characters to be used.
However, if you try to run a build using such a rootDir, the build of sd-setup-launcher will fail.

We will make corrections in the future.

@jithine
Copy link
Member

jithine commented Dec 14, 2023

Closing this, please re-open if there are more tasks pending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants