Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(2952): Allow to cd to rootDir containing special characters #219

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

yk634
Copy link
Contributor

@yk634 yk634 commented Nov 28, 2023

Context

Special characters can now be used in rootDir, but cannot be cd'd if they contain double-byte spaces, etc.

Objective

  • Enclose the directory specified by the cd command in single quotes.
  • Escapes single quotes in rootDir.

References

screwdriver-cd/screwdriver#2952

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@tkyi tkyi merged commit 3fd29c2 into screwdriver-cd:master Nov 28, 2023
2 checks passed
@sd-buildbot
Copy link

🎉 This PR is included in version 12.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yk634 yk634 deleted the cd-rootdir branch July 17, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants