Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check if a user is admin of a pipeline #1387

Merged
merged 3 commits into from
Nov 20, 2018
Merged

feat: check if a user is admin of a pipeline #1387

merged 3 commits into from
Nov 20, 2018

Conversation

d2lam
Copy link
Member

@d2lam d2lam commented Nov 16, 2018

Need this endpoint so that we can call from the store to invalidate the cache.

Related:
#1385
screwdriver-cd/store#67

@coveralls
Copy link

coveralls commented Nov 16, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build #85

  • 26 of 26 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.516%
Totals Coverage Status
Change from base Build #78: 0.005%
Covered Lines: 2524
Relevant Lines: 2524
💛 - Coveralls

tkyi
tkyi reviewed Nov 16, 2018
View reviewed changes
plugins/pipelines/isAdmin.js Outdated Show resolved Hide resolved
@d2lam d2lam changed the title feat: check if a user is admin of a pipeline [WIP] feat: check if a user is admin of a pipeline Nov 16, 2018
@d2lam d2lam changed the title [WIP] feat: check if a user is admin of a pipeline feat: check if a user is admin of a pipeline Nov 19, 2018
tkyi
tkyi approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pranavrc
pranavrc approved these changes Nov 20, 2018
View reviewed changes
Copy link

@pranavrc pranavrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@d2lam d2lam merged commit 34f2157 into master Nov 20, 2018
@d2lam d2lam deleted the isadmin branch November 20, 2018 20:02
@d2lam d2lam mentioned this pull request Nov 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavrc pranavrc pranavrc approved these changes

@tkyi tkyi tkyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d2lam @coveralls @pranavrc @tkyi