Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(2911): Job Templates - Pipeline Usage Report #2912

Merged
merged 23 commits into from
Sep 5, 2023

Conversation

nathom
Copy link
Contributor

@nathom nathom commented Aug 9, 2023

Context

To enable the pipeline usage enhancement

Objective

Allow a client to retrieve a summary of pipelines using a template version.

References

#2911

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@nathom nathom marked this pull request as draft August 9, 2023 18:16
@nathom nathom changed the title Add template/{id}/metrics endpoint Add endpoint to retrieve single template with metrics Aug 11, 2023
@nathom nathom marked this pull request as ready for review August 11, 2023 18:33
@coveralls
Copy link

coveralls commented Aug 15, 2023

Coverage Status

coverage: 94.985% (+0.02%) from 94.97% when pulling a7ceca9 on nathom:pipeline_count into 1f56b06 on screwdriver-cd:master.

Copy link
Member

@tkyi tkyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update template README with the new endpoint: https://github.com/screwdriver-cd/screwdriver/blob/master/plugins/templates/README.md

And add tests

plugins/templates/getPipelineUsage.js Outdated Show resolved Hide resolved
plugins/templates/getPipelineUsage.js Show resolved Hide resolved
@nathom nathom changed the title Add endpoint to retrieve single template with metrics Job Templates - Pipeline Usage Report Aug 24, 2023
@sagar1312 sagar1312 changed the title Job Templates - Pipeline Usage Report feat(2911): Job Templates - Pipeline Usage Report Aug 31, 2023
plugins/templates/README.md Outdated Show resolved Hide resolved
plugins/templates/README.md Show resolved Hide resolved
plugins/templates/getPipelineUsage.js Outdated Show resolved Hide resolved
plugins/templates/getPipelineUsage.js Outdated Show resolved Hide resolved
test/plugins/data/templateVersionsMetrics.json Outdated Show resolved Hide resolved
test/plugins/templates.test.js Outdated Show resolved Hide resolved
test/plugins/templates.test.js Outdated Show resolved Hide resolved
# This is the 1st commit message:

Update plugins/templates/README.md

Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
# This is the commit message screwdriver-cd#2:

Comply with eslint rules

# This is the commit message screwdriver-cd#3:

Update error handling

Fix test data

Verify error message in test
Update plugins/templates/README.md

Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>

Comply with eslint rules

Update error handling

Fix test data

Verify error message in test

Update error handling

Update plugins/templates/README.md

Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>

Comply with eslint rules

Update error handling

Fix test data

Verify error message in test

Update error handling
Co-authored-by: Dayanand Sagar <sagar1312@gmail.com>
@sagar1312 sagar1312 merged commit cc915df into screwdriver-cd:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants