Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(3036): update hapi-swagger package #3039

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

y-oksaku
Copy link
Contributor

@y-oksaku y-oksaku commented Feb 22, 2024

Context

Cullently Swagger plugin version is v2, but this version does not support some feature.
#3036

Objective

Bump up hapi/swagger module.
After this PR, we will use OpenAPI v3 but its setting file is automatically generated by hapi/swagger.

References

#3036

License

I confirm that this contribution is made under a BSD license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 95.113%. remained the same
when pulling 98cdb53 on sonic-screwdriver-cd:update-swagger
into 90a0c61 on screwdriver-cd:master.

@yakanechi
Copy link
Contributor

@y-oksaku
Would you change the plugins/swagger.js described in the objective in another PR?

@y-oksaku
Copy link
Contributor Author

I added v3 updating in this PR since there seems to be little advantage to separating PR.

@tkyi tkyi merged commit 02306e7 into screwdriver-cd:master Feb 22, 2024
2 checks passed
@y-oksaku y-oksaku deleted the update-swagger branch February 22, 2024 23:59
@adong adong mentioned this pull request Mar 4, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants