fix(build metrics): clean up route & controller on exit (#439)

app/pipeline/metrics/controller.js

@@ -62,6 +62,21 @@ export default Controller.extend({
       );
     }
   }),
+  init() {
+    this._super(...arguments);
+    this.reinit();
+  },
+  reinit() {
+    // clear all those flags b/c this is a controller
+    this.set('selectedRange', '1wk');
+    this.set('inTrendlineView', false);
+    this.set('isUTC', false);
+
+    // safety step to release references
+    this.set(this.get('eventsChartName'), null);
+    this.set(this.get('buildsChartName'), null);
+    this.set(this.get('stepsChartName'), null);
+  },
   /**
    * Memoized range generator
    * Generator code borrowed from MDN:

app/pipeline/metrics/route.js

@@ -5,7 +5,9 @@ import timeRange from 'screwdriver-ui/utils/time-range';
 export default Route.extend({
   init() {
     this._super(...arguments);
-
+    this.reinit();
+  },
+  reinit() {
     const { startTime, endTime } = timeRange(new Date(), '1wk');
 
     // these are used for querying, so they are in ISO8601 format
@@ -28,12 +30,8 @@ export default Route.extend({
     this.set('fetchJob', false);
   },
   deactivate() {
-    const controller = this.controllerFor('pipeline.metrics');
-
-    // safety step to release references
-    controller.set('eventsChart', null);
-    controller.set('buildsChart', null);
-    controller.set('stepsChart', null);
+    this.reinit();
+    this.controllerFor('pipeline.metrics').reinit();
   },
   model() {
     const controller = this.controllerFor('pipeline.metrics');
@@ -231,7 +229,7 @@ export default Route.extend({
       this.refresh();
     },
     filterSuccessOnly() {
-      this.set('successOnly', !this.get('successOnly'));
+      this.toggleProperty('successOnly');
       this.refresh();
     }
   }

app/pipeline/metrics/template.hbs

@@ -23,8 +23,6 @@
       clickOpens=true
       dateFormat='m/d/Y'
       date=customRange
-      flatpickrRef=flatpickrRef
-      getFlatpickrRef=(action (mut flatpickrRef))
       locale="en"
       mode="range"
       onChange=(action (mut dateValues))