Refactor video format attribute handling

scrollup · Sep 16, 2016 · 9b819b2 · 9b819b2
1 parent db1ff85
commit 9b819b2
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/formats/video.js b/formats/video.js
@@ -1,6 +1,11 @@
 import { BlockEmbed } from '../blots/block';
 import Link from '../formats/link';
 
+const ATTRIBUTES = [
+  'height',
+  'width'
+];
+
 
 class Video extends BlockEmbed {
   static create(value) {
@@ -12,10 +17,12 @@ class Video extends BlockEmbed {
   }
 
   static formats(domNode) {
-    let formats = {};
-    if (domNode.hasAttribute('height')) formats['height'] = domNode.getAttribute('height');
-    if (domNode.hasAttribute('width')) formats['width'] = domNode.getAttribute('width');
-    return formats;
+    return ATTRIBUTES.reduce(function(formats, attribute) {
+      if (domNode.hasAttribute(attribute)) {
+        formats[attribute] = domNode.getAttribute(attribute);
+      }
+      return formats;
+    }, {});
   }
 
   static sanitize(url) {
@@ -27,7 +34,7 @@ class Video extends BlockEmbed {
   }
 
   format(name, value) {
-    if (name === 'height' || name === 'width') {
+    if (ATTRIBUTES.indexOf(name) > -1) {
       if (value) {
         this.domNode.setAttribute(name, value);
       } else {