Clean after merge

examples/examples/benchmark_bulk_xt.rs

@@ -28,7 +28,7 @@ use substrate_api_client::{
 	Api, SubmitExtrinsic,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/compose_extrinsic_offline.rs

@@ -25,7 +25,7 @@ use substrate_api_client::{
 	Api, GetHeader, SubmitAndWatch, XtStatus,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/contract_instantiate_with_code.rs

@@ -25,7 +25,7 @@ use substrate_api_client::{
 	SubmitAndWatch, SubmitAndWatchUntilSuccess, XtStatus,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/custom_nonce.rs

@@ -25,7 +25,7 @@ use substrate_api_client::{
 	Api, Error, GetHeader, SubmitAndWatch, UnexpectedTxStatus, XtStatus,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/event_error_details.rs

@@ -24,7 +24,7 @@ use substrate_api_client::{
 	Api, GetAccountInformation, SubmitAndWatchUntilSuccess,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/get_account_identity.rs

@@ -34,7 +34,7 @@ type BalanceOf<T> = <<T as pallet_identity::Config>::Currency as Currency<
 type MaxRegistrarsOf<T> = <T as pallet_identity::Config>::MaxRegistrars;
 type MaxAdditionalFieldsOf<T> = <T as pallet_identity::Config>::MaxAdditionalFields;
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/get_blocks.rs

@@ -23,7 +23,7 @@ use substrate_api_client::{
 	Api, GetBlock, GetHeader, SubscribeChain,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/get_storage.rs

@@ -24,7 +24,7 @@ use substrate_api_client::{
 	Api, GetAccountInformation, GetStorage,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the different related types.

examples/examples/print_metadata.rs

@@ -19,12 +19,12 @@
 use sp_runtime::traits::GetRuntimeBlockType;
 use substrate_api_client::{ac_primitives::SubstrateConfig, rpc::JsonrpseeClient, Api};
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.
 type KitchensinkConfig =
-SubstrateConfig<<kitchensink_runtime::Runtime as GetRuntimeBlockType>::RuntimeBlock>;
+	SubstrateConfig<<kitchensink_runtime::Runtime as GetRuntimeBlockType>::RuntimeBlock>;
 
 #[tokio::main]
 async fn main() {

examples/examples/staking_batch_payout.rs

@@ -24,7 +24,7 @@ use substrate_api_client::{
 
 const MAX_BATCHED_TRANSACTION: u32 = 9;
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/sudo.rs

@@ -31,7 +31,7 @@ use substrate_api_client::{
 	Api, GetAccountInformation, SubmitAndWatch, XtStatus,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/transfer_with_tungstenite_client.rs

@@ -27,7 +27,7 @@ use substrate_api_client::{
 	Api, GetAccountInformation, SubmitAndWatch, XtStatus,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

examples/examples/transfer_with_ws_client.rs

@@ -27,7 +27,7 @@ use substrate_api_client::{
 	Api, GetAccountInformation, SubmitAndWatch, XtStatus,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

primitives/src/config/substrate_config.rs

@@ -21,8 +21,6 @@ use sp_core::sr25519;
 use sp_runtime::{traits::Block as BlockTrait, AccountId32, MultiAddress, MultiSignature};
 
 /// Default set of commonly used types by Substrate runtimes.
-// Note: We only use this at the type level, so it should be impossible to
-// create an instance of it.
 #[derive(Decode, Encode, Clone, Eq, PartialEq, Debug)]
 pub struct SubstrateConfig<Block> {
 	_marker: PhantomData<Block>,
@@ -36,7 +34,7 @@ where
 	type Hash = H256;
 	type AccountId = AccountId32;
 	type Address = MultiAddress<Self::AccountId, u32>;
-	type Signature = MultiSignature; //sr25519::Signature
+	type Signature = MultiSignature;
 	type Hasher = BlakeTwo256;
 	type Header = SubstrateHeader<u32, BlakeTwo256>;
 	type AccountData = AccountData<Self::Balance>;

primitives/src/extrinsics/signer.rs

@@ -20,7 +20,8 @@
 use crate::config::Config;
 use codec::{Decode, Encode};
 use core::marker::PhantomData;
-use sp_core::Pair;
+use sp_core::{crypto::AccountId32, Pair};
+use sp_runtime::MultiAddress;
 
 pub trait SignExtrinsic<AccountId: Clone + Encode> {
 	type Signature: Encode;
@@ -84,7 +85,7 @@ where
 		&self.account_id
 	}
 
-	fn extrinsic_address(&self) -> T::Address {
+	fn extrinsic_address(&self) -> Self::ExtrinsicAddress {
 		self.extrinsic_address.clone()
 	}
 }
@@ -99,8 +100,7 @@ where
 		ExtrinsicSigner::<T, Signer>::new(value)
 	}
 }
-//Todo: check if still needed, because of config
-/*
+
 /// Extrinsic Signer implementation, that does not enforce Runtime as input.
 /// This is especially useful in no-std environments, where the runtime is not
 /// available.
@@ -149,7 +149,6 @@ where
 		self.extrinsic_address.clone()
 	}
 }
- */
 
 #[cfg(test)]
 mod tests {
@@ -172,7 +171,6 @@ mod tests {
 
 		assert_eq!(es_converted.signer.public(), es_new.signer.public());
 	}
-	// This test does not work. See issue #504.
 
 	#[test]
 	fn test_extrinsic_signer_clone() {
@@ -181,15 +179,4 @@ mod tests {
 
 		let _signer2 = signer.clone();
 	}
-
-	//Todo: still needed?
-	/*
-	   #[test]
-	   fn test_static_extrinsic_signer_clone() {
-		   let pair = AccountKeyring::Alice.pair();
-		   let signer = StaticExtrinsicSigner::<_, Signature>::new(pair);
-
-		   let _signer2 = signer.clone();
-	   }
-	*/
 }

src/api/rpc_api/chain.rs

@@ -80,7 +80,7 @@ where
 	Client: Request,
 	<T::Header as ac_primitives::config::Header>::Number: Serialize,
 {
-	type BlockNumber = <T::Header as crate::config::Header>::Number;
+	type BlockNumber = <T::Header as ac_primitives::config::Header>::Number;
 	type Hash = T::Hash;
 	type Block = T::Block;
 

testing/examples/author_tests.rs

@@ -28,7 +28,7 @@ use substrate_api_client::{
 	Api, SubmitAndWatch, SubmitAndWatchUntilSuccess, SubmitExtrinsic, TransactionStatus, XtStatus,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

testing/examples/chain_tests.rs

@@ -22,7 +22,7 @@ use substrate_api_client::{
 	Api, GetBlock, GetHeader, SubscribeChain,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

testing/examples/events_tests.rs

@@ -39,7 +39,7 @@ impl StaticEvent for ExtrinsicSuccess {
 	const EVENT: &'static str = "ExtrinsicSuccess";
 }
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

testing/examples/frame_system_tests.rs

@@ -26,7 +26,7 @@ use substrate_api_client::{
 	Api, GetAccountInformation, SystemApi,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

testing/examples/pallet_balances_tests.rs

@@ -18,7 +18,7 @@
 use sp_runtime::traits::GetRuntimeBlockType;
 use substrate_api_client::{ac_primitives::SubstrateConfig, rpc::JsonrpseeClient, Api, GetBalance};
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

testing/examples/pallet_transaction_payment_tests.rs

@@ -25,7 +25,7 @@ use substrate_api_client::{
 	Api, GetBlock, GetTransactionPayment,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the config type.

testing/examples/state_tests.rs

@@ -28,7 +28,7 @@ use substrate_api_client::{
 	Api, GetBlock, GetStorage,
 };
 
-// This example run against a specific  node.
+// This example run against a specific node.
 // We use the substrate kitchensink runtime: the config is a substrate config with the kitchensink runtime block type.
 // ! Careful: Most runtimes uses plain as tips, they need a polkadot config.
 // For better code readability, we define the related types.