Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pallet-staking and pallet-contracts dependencies optional #522

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Apr 6, 2023

Include pallet-staking dependency only when staking-xt feature is enabled.
pallet-contracts is implemented along the same lines. pallet-contracts has a dependency on wasmi so it is nice if we can make this optional.

@Niederb Niederb changed the title Make pallet-staking dependency optional Make pallet-staking and pallet-contracts dependencies optional Apr 11, 2023
@Niederb Niederb self-assigned this Apr 11, 2023
@Niederb Niederb linked an issue Apr 11, 2023 that may be closed by this pull request
@Niederb Niederb marked this pull request as ready for review April 11, 2023 07:13
@Niederb Niederb force-pushed the tn/pallet-staking-dependency branch from 868969d to cbdd96d Compare April 11, 2023 07:13
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks !

@haerdib haerdib added the F7-enhancement Enhances an already existing functionality label Apr 11, 2023
@Niederb Niederb merged commit 62f0db9 into master Apr 11, 2023
@Niederb Niederb deleted the tn/pallet-staking-dependency branch April 19, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2-breaksapi F7-enhancement Enhances an already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate: What dependencies should be made optional
3 participants