-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up dependencies and fix primitives no_std build #535
Conversation
@@ -77,8 +77,7 @@ async fn main() { | |||
let string_error = format!("{:?}", e); | |||
// We expect a TokenError::FundsUnavailable error. See : | |||
//https://github.com/paritytech/substrate/blob/b42a687c9050cbe04849c45b0c5ccadb82c84948/frame/support/src/traits/tokens/fungible/mod.rs#L177 | |||
assert!(string_error.contains("Other")); | |||
assert!(string_error.contains("[7, 0, 194, 110, 3, 65, 37, 56, 0, 0]")); //Fixme This is for now not decoded. See issue: #488 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assert failed for some reason (different error seems to be returned now). However, since we cant decode this error anyway, I don't see much sense in asserting the error. Removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree with this reasoning.
@@ -77,8 +77,7 @@ async fn main() { | |||
let string_error = format!("{:?}", e); | |||
// We expect a TokenError::FundsUnavailable error. See : | |||
//https://github.com/paritytech/substrate/blob/b42a687c9050cbe04849c45b0c5ccadb82c84948/frame/support/src/traits/tokens/fungible/mod.rs#L177 | |||
assert!(string_error.contains("Other")); | |||
assert!(string_error.contains("[7, 0, 194, 110, 3, 65, 37, 56, 0, 0]")); //Fixme This is for now not decoded. See issue: #488 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree with this reasoning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup and improvement of no_std verification 🥳
As preparatory steps for publishing on crates.io:
Clean up the toml files:
Additionally, found while cleaning dependencies:
Removed
assert
in error example because it constantly failed (substrate upgrade?). But since there is no decoding anyway, I don't see the use case in checking the encoded error.Last, but not least: