Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remotezip #401

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Remove remotezip #401

merged 8 commits into from
Oct 16, 2023

Conversation

wxicu
Copy link
Collaborator

@wxicu wxicu commented Oct 16, 2023

PR Checklist

Description of changes

  1. Download the expression data from figshare
  2. change cache dir
  3. remove remotezip

Technical details

Additional context
The expression data still contains random white space. This should be replaced after depmap team updates the data.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #401 (a396424) into main (67ee210) will not change coverage.
The diff coverage is 0.00%.

❗ Current head a396424 differs from pull request most recent head 8bbe14e. Consider uploading reports for the commit 8bbe14e to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #401   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         40      40           
  Lines       4888    4877   -11     
=====================================
+ Misses      4888    4877   -11     
Files Coverage Δ
pertpy/tools/_metadata/_cell_line.py 0.00% <0.00%> (ø)

…o dev_metadata

* 'dev_metadata' of https://github.com/theislab/pertpy:
  Documentation examples (#391)
  [pre-commit.ci] pre-commit autoupdate (#395)
  Speed up tests by subsampling (#398)
  Installation Apple Silicon (#393)
  Add new distances (#304)
  Fix cinema OT test (#392)
  [pre-commit.ci] pre-commit autoupdate (#390)
  wasserstein distance return type float (#386)
  fix naming of example data in doc examples (#387)
  Add test for test_distances.py Catches error as reported in Issue #385.
  Fix mypy warning for distances Type hint for `groups` reverted, Iterable is too general.
Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some minor comments

wxicu and others added 3 commits October 16, 2023 21:50
Fix quote

Co-authored-by: Lukas Heumos <lukas.heumos@posteo.net>
Co-authored-by: Lukas Heumos <lukas.heumos@posteo.net>
@wxicu wxicu merged commit b01f318 into main Oct 16, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants