Skip to content
This repository has been archived by the owner on Feb 3, 2018. It is now read-only.

Ignore underscore-led files on parse #211

Closed
sdboyer opened this issue Apr 7, 2017 · 1 comment
Closed

Ignore underscore-led files on parse #211

sdboyer opened this issue Apr 7, 2017 · 1 comment
Labels
bug correctness

Comments

@sdboyer
Copy link
Owner

sdboyer commented Apr 7, 2017

golang/dep#351 demonstrated how parsing in files with leading underscores leads to all manner of problems. In that case, a _gen.go file from github.com/clipperhouse/gen ended up tricking our package parser into thinking that it was all a package main.

The toolchain doesn't look at these files by default when compiling, and we shouldn't analyze them either.
@sdboyer sdboyer closed this as completed in a6fdcf9 Apr 7, 2017
@sdboyer
Copy link
Owner Author

sdboyer commented Apr 7, 2017

Technically this should result in a solver version bump, but #173 ain't in yet :(

krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
@sdboyer
Ignore underscore-led files when parsing
a33a859 
Fixes sdboyer/gps#211.
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 21, 2017
@sdboyer @krisnova
Ignore underscore-led files when parsing
d40a5ff 
Fixes sdboyer/gps#211.
krisnova pushed a commit to krisnova/dep that referenced this issue Apr 25, 2017
@sdboyer @krisnova
Ignore underscore-led files when parsing
c70bf4d 
Fixes sdboyer/gps#211.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug correctness
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdboyer