This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commits on Aug 18, 2018
-
Logic: Teach the app to accept 'remark' but do nothing
. Add a RemarkCommand that just throws an Exception. . Add RemarkCommandTest that will test that executeUndoableCommand() throws an Exception. . Modify AddressBookParser to accept a RemarkCommand. . Add new test to AddressBookParserTest, which will test that typing "remark" returns an instance of RemarkCommand.
Configuration menu - View commit details
-
Copy full SHA for 1ebeded - Browse repository at this point
Copy the full SHA 1ebededView commit details
Commits on Aug 21, 2018
-
Logic: Teach the app to accept 'remark' arguments but still do nothing
. Modify RemarkCommand to take in an Index and String for remark, and print those two parameters as the error message . Modify RemarkCommandTest to test the equals method . Add RemarkCommandParser that will know how to parse two arguments, one index and one with prefix 'r/' . Add RemarkCommandParserTest that will test different boundary values for RemarkCommandParser. . Modify AddressBookParser to use the newly implemented RemarkCommandParser . Modify AddressBookParserTest to ensure that what the user input generated the correct command.
Configuration menu - View commit details
-
Copy full SHA for caae7a8 - Browse repository at this point
Copy the full SHA caae7a8View commit details -
Ui: Add a placeholder for remark in PersonCard GUI
. Add label with any random text inside PersonListCard.fxml . Add FXML annotation in PersonCard to tie the variable to the actual label. . Modify PersonCardHandle so that future tests can read the remarks in the cards.
Configuration menu - View commit details
-
Copy full SHA for 3d5983b - Browse repository at this point
Copy the full SHA 3d5983bView commit details -
. Add Remark to model component (copy from Address, remove the regex and rename accordingly). . Add test for Remark (to test the equals method). . Modify RemarkCommand to now take in a Remark instead of a String.
Configuration menu - View commit details
-
Copy full SHA for ae53a78 - Browse repository at this point
Copy the full SHA ae53a78View commit details -
Model: Modify
Person
to support aRemark
field. Add `Person#getRemark()` . You may assume that the user will not be able to use the `add` and `edit` commands to modify the remarks field (i.e. the person will be created without a remark). . Modify `SampleDataUtil` to add remarks for the sample data. I recommend deleting your addressBook.xml after this step so that you can see the remarks field come to life in your application.
Configuration menu - View commit details
-
Copy full SHA for 6e87781 - Browse repository at this point
Copy the full SHA 6e87781View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bee27e - Browse repository at this point
Copy the full SHA 9bee27eView commit details -
Test: Add withRemark() for PersonBuilder
. Add a new method `withRemark()` for `PersonBuilder`. This method will create a new `Remark` for the person that it is currently building. . Try and use the method on any sample `Person` in `TypicalPersons`.
Configuration menu - View commit details
-
Copy full SHA for b3a1c56 - Browse repository at this point
Copy the full SHA b3a1c56View commit details -
Ui: Connect Remark field to PersonCard
. Just modify PersonCard's constructor to add the new method. . For test, modify GuiTestAssert#assertCardDisplaysPerson(...) to compare the now-functioning remark label.
Configuration menu - View commit details
-
Copy full SHA for e841d50 - Browse repository at this point
Copy the full SHA e841d50View commit details -
Logic: Implement RemarkCommand execute() logic
. Replace the error message with the actual logic to modify the remarks of a person. . Update `RemarkCommandTest` to test that the `execute()` logic works.
Configuration menu - View commit details
-
Copy full SHA for 8e446e8 - Browse repository at this point
Copy the full SHA 8e446e8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.