Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ReverseLookup to TypeService #185

Merged
merged 5 commits into from
Jun 11, 2019

Conversation

wedge206
Copy link
Contributor

@wedge206 wedge206 commented May 31, 2019

This is required to fix a bug when queries do not specify a type.

I don't know if the method should call FirstOrDefault() or SingleOrDefault().
I used FirstOrDefault for safety. But I feel Single is more correct. There should never be more than one type mapped to the same value.

#183

@wedge206
Copy link
Contributor Author

Is this one okay to be approved?

@sebastienros sebastienros merged commit 5b26a95 into sebastienros:dev Jun 11, 2019
@sebastienros
Copy link
Owner

Thanks, had forgotten about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants