-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Polyline): add an input() property "icons" to AgmPolyline #1594
fix(Polyline): add an input() property "icons" to AgmPolyline #1594
Conversation
the icons to be rendered along the polyline we can draw dashed lines with it
Codecov Report
@@ Coverage Diff @@
## master #1594 +/- ##
==========================================
+ Coverage 37.55% 37.59% +0.03%
==========================================
Files 37 37
Lines 1651 1652 +1
Branches 133 133
==========================================
+ Hits 620 621 +1
Misses 1029 1029
Partials 2 2
Continue to review full report at Codecov.
|
Hi When will this PR to be done? |
hey, @ziye201810 thanks for submitting work. Polyline icons must also support predefined SymbolPaths. Can you add that to google-types? |
Is there any alternative of implementing icons property till icons property is added in agm-polyline |
Hi any news on this ? |
the creator of the PR is not responding to my change request, but this is a high priority thing so I think I'll just fork it and do it myself. Not promising, but should be done by end of week. |
@doom777 Got it. Yeah sorry I commented too fast. Have been requesting this (and monitoring the closed issues) for quite some time now. Indeed this is becoming quite high prio as most maps need those kinda arrows and so on. Thanks for the reply, good luck and you have already my kudos! |
implemented by my PR |
the icons to be rendered along the polyline
we can draw dashed lines with it
(I need to draw dashed line in my application but seems icons property is missing in AgmPloyline Class. ref:https://developers.google.com/maps/documentation/javascript/examples/overlay-symbol-dashed )