Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Polyline): add an input() property "icons" to AgmPolyline #1594

Closed

Conversation

ziye201810
Copy link

the icons to be rendered along the polyline
we can draw dashed lines with it
(I need to draw dashed line in my application but seems icons property is missing in AgmPloyline Class. ref:https://developers.google.com/maps/documentation/javascript/examples/overlay-symbol-dashed )

the icons to be rendered along the polyline
we can draw dashed lines with it
@codecov
Copy link

codecov bot commented Feb 12, 2019

Codecov Report

Merging #1594 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1594      +/-   ##
==========================================
+ Coverage   37.55%   37.59%   +0.03%     
==========================================
  Files          37       37              
  Lines        1651     1652       +1     
  Branches      133      133              
==========================================
+ Hits          620      621       +1     
  Misses       1029     1029              
  Partials        2        2
Impacted Files Coverage Δ
...ackages/core/services/managers/polyline-manager.ts 63.63% <ø> (ø) ⬆️
packages/core/directives/polyline.ts 50% <100%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0442aa0...f6689c0. Read the comment docs.

@kezlee
Copy link

kezlee commented Feb 22, 2019

Hi When will this PR to be done?

@ghost ghost mentioned this pull request May 30, 2019
@ghost
Copy link

ghost commented Jun 2, 2019

hey, @ziye201810 thanks for submitting work.

Polyline icons must also support predefined SymbolPaths. Can you add that to google-types?

image

@puneet24
Copy link

Is there any alternative of implementing icons property till icons property is added in agm-polyline

@jimmykane
Copy link

Hi any news on this ?

@ghost
Copy link

ghost commented Jun 26, 2019

the creator of the PR is not responding to my change request, but this is a high priority thing so I think I'll just fork it and do it myself. Not promising, but should be done by end of week.

@jimmykane
Copy link

@doom777 Got it. Yeah sorry I commented too fast. Have been requesting this (and monitoring the closed issues) for quite some time now.

Indeed this is becoming quite high prio as most maps need those kinda arrows and so on.

Thanks for the reply, good luck and you have already my kudos!

@ghost
Copy link

ghost commented Jul 3, 2019

implemented by my PR

@ghost ghost closed this Jul 3, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants