Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url API changes #472

Closed
wants to merge 12 commits into from
Closed

Url API changes #472

wants to merge 12 commits into from

Commits on May 30, 2020

  1. Extract UrlSearch struct into a submodule.

    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    b70441b View commit details
    Browse the repository at this point in the history

  2. Split methods in Url by purpose 

    - constructors
- getters
- setters
- browser actions involving `Url`
- browser actions independent of `Url`
- manipulation of what I'm calling the `base_path` and `active_path` for now
- A "miscellaneous" section that only has one function (decoding percent encoded strings)

Marked a few TODOs for thinking about, not immediately actionable.
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    fb3ca39 View commit details
    Browse the repository at this point in the history

  3. Flatten + tweak 

    Small change, will be mostly untouched in the rest of the changes.

Attempt to lessen the rightward "drift" of the code. Also since `filter_map` is rarely used.
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    13cab29 View commit details
    Browse the repository at this point in the history

  4. Update examples so that they compile. 

    rename everything in terms of `base` path and `relative` path
pop/push to maintain consistency with `Vec` (potentially rename pop to shift for clarity)
try added to note that the attempt can fail
`set_hash` changed to depend on `set_hash_path`
`go_and_load` changed to depend on `go_and_load_with_str`
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    5587f29 View commit details
    Browse the repository at this point in the history

  5. Update examples to match rename

    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    7661ec2 View commit details
    Browse the repository at this point in the history

  6. Implement base_path + relative_path

    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    08d95f0 View commit details
    Browse the repository at this point in the history

  7. Update truncate_* to act in place 

    Also move two functions further down
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    960f3cc View commit details
    Browse the repository at this point in the history

  8. Make set_search take a UrlSearch instead of an Into<UrlSearch> 

    Implicit conversions tend to cause spikes in processing. Also, makes it work more nicely with a later change.
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    91d54d4 View commit details
    Browse the repository at this point in the history

  9. Remove ref on truncate_ 

    Seems to make it hard to work with sometimes.
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    ea4227a View commit details
    Browse the repository at this point in the history

  10. Add FromIterator impl for UrlSearch 

    Also, repurposed the now redundant `new` method to create an empty `UrlSearch`
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    f528783 View commit details
    Browse the repository at this point in the history

  11. Oops, missed a spot.

    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    e2f4dd1 View commit details
    Browse the repository at this point in the history

  12. Running cargo fmt, since I need to figure out how to run cargo make t… 

    …est in the meantime
    @AlterionX
    AlterionX committed May 30, 2020
    Configuration menu
    Copy the full SHA
    7ef5fbf View commit details
    Browse the repository at this point in the history