Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing iOS load issue with react native 0.56 #18

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

virdesai
Copy link
Contributor

No description provided.

@Marcsimm
Copy link

Marcsimm commented Jul 19, 2018

When can this be merged? this is quite urgent for us

@virdesai
Copy link
Contributor Author

virdesai commented Jul 19, 2018

@Marcsimm I don't have the ability to merge it otherwise I would

in the mean time, you could use this command after installing:
sed -i '' 's/<WebView/<WebView originWhitelist={["*"]}/' ./node_modules/react-native-remote-svg/SvgImage.js

@seekshiva
Copy link
Owner

@virdesai Sorry for the delay. Can you provide more detail about how this change helps or the problem it solves?

Thanks

@virdesai
Copy link
Contributor Author

virdesai commented Aug 3, 2018

@seekshiva on the current version of react-native, 0.56.0, WebView on iOS cannot load local assets without this wildcard origin whitelisting

@joerichsen
Copy link

I had the same problem after upgrading to 0.56 and the solution that @virdesai provides solves it 👍

The issue is described here facebook/react-native#19986

Maybe it is the source of the problem in this issue as well?
#19

@seekshiva seekshiva merged commit 1976498 into seekshiva:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants