2022 Strix G17 - 0.134 Ambient & Heatmap issue.

[Constrat]

Describe the bug
0.132 and 0.133 Heatmap & Ambient light mode, light the entire keyboard up.
With 0.134 they will not light up the numpad, the <>.
Probably related: the same issue happens with OpenRGB when the layout is not correctly identified (15'' vs 17'' have different layouts because of numpad presence)

Clear scenario to Reproduce
Steps to reproduce the behavior:

1. Go to Laptop Keyboard
2. Choose Ambient or Hetmap
3. Parts of the keyboard will not light up.

Expected behavior
Entire keyboard should light up.

App Logs
log has the light up actions for the 3 different version. I noticed that for 0.134 an error is shown:
21/11/23 20:45:25: Error writing USB: Operation failed early: The parameter is incorrect.
log.txt

Screenshots or screencasts

Image looks ugly my bad

Desktop (please complete the following information):

• OS: Win11 Enterprise
• ROG Strix G17 G713RW

Asus software
Completely free from Asus Bloat (Thank you Seerge)

[seerge]

@Constrat does your laptop has per-key RGB or with zones ? if with zones try this build
GHelper.zip

[Constrat]

Only the lightbar lights up. (In GPU Mode and Ambient mode and Heatmap Mode)
This laptop has per-key coloring possible if that's what you mean.

[seerge]

@Constrat then i'm inviting you to participate :) instead of blindly sending colors to all possible (and impossible) hotkeys i took per-key implementation from openrgb (so no wonder you have same experience as there)

This is array with addresses of each key in the payload
https://github.com/seerge/g-helper/blob/main/app/USB/Aura.cs#L362

I have tried to fill in gaps with assumed num-lock buttons (but i have no idea if they are correct)
You can try this build and check which buttons light up

GHelper.zip

[Constrat]

But we're there any big changes between 0.133 and 0.134? Because it was working properly before.
Also. The ORGB fork is still unmerged (with the 17'' fixes)

I'll see what I can do tomorrow :)

[seerge]

@Constrat yes, for 0.134 I have added proper per-key mapping for RGB *check discussion) #1582 before it was just setting same color to all possible addresses (which was making proper ambient with multiple zones impossible)

Does build that I have linked here light up some of numpad keys ?

[Constrat]

You'll have to wait tomorrow morning / lunch, because I've already turned off everything as I'm about to go to bed. Tmr in uni I think I have 1 hour free. I should be able to give you everything/ test the key values

[Constrat]

Ok so most of the numpad now lights up (<> 0 num and . num are still missing) also the 1 num and ctrl don't seem to be in the correct place.
I'll see what I can do with https://github.com/seerge/g-helper/blob/main/app/USB/Aura.cs#L362
is this update to the .zip you passed me?

[seerge]

@Constrat then i guessed in more-or-less right direction. Don't forget second array

https://github.com/seerge/g-helper/blob/main/app/USB/Aura.cs#L397

that marks which zone (i..e color) should new keys represent. It should be 3 (last 4th zone). So when you add a new key - you need to add it to both arrays in same position :)

[Constrat]

So for example the NUM1 that has the "wrong" color just needs to be changed zone?
Thank you for the input :)

...Why does NUM1 go at the end.

Oh I see the problem, you've probably made a translation for the numpad.
Ok I think I've identified the translation., it's a minus 1, Left control and NUM1 are like inverted

[seerge]

@Constrat only if numpad 1 key is identified correctly :)

[Constrat]

I'm making it work :) this is so cool, seeing the keys light up based on the numbers.
I should be able to copy all the values from the ORGB branch I was working on a while back,
This is for the 17''. I don't know how G-Helper would react in case there are less keys addressable

  /* ESC          F1    F2    F3    F4    F5    F6    F7    F8    F9   F10   F11   F12   NULL  NULL  PAUS                          */
      21,         23,   24,   25,   26,   28,   29,   30,   31,   33,   34,   35,   36,    0,    0,   39,
  /* BKTK    1     2     3     4     5     6     7     8     9     0     -     =   BSPC  NULL  NULL  NULL  NMLK  NMDV  NMTM  NMMI  */
      42,   43,   44,   45,   46,   47,   48,   49,   50,   51,   52,   53,   54,   56,    0,    0,    0,   59,   60,   61,   62,
  /* TAB     Q     W     E     R     T     Y     U     I     O     P     [     ]     \   NULL  NULL  NULL  NM7   NM8   NM9   NMPL  */
      63,   64,   65,   66,   67,   68,   69,   70,   71,   72,   73,   74,   75,   76,    0,    0,    0,   80,   81,   82,   83,
  /* CPLK    A     S     D     F     G     H     J     K     L     ;     "     #   ENTR                    NM4   NM5   NM6         */
      84,   85,   86,   87,   88,   89,   90,   91,   92,   93,   94,   95,   96,   98,                    101,  102,  103,
  /* LSFT  ISO\    Z     X     C     V     B     N     M     ,     .     /   RSFT              ARWU        NM1   NM2   NM3   NMER  */
     105,  106,  107,  108,  109,  110,  111,  112,  113,  114,  115,  116,  119,              139,        122,  123,  124,  125,
  /* LCTL  LWIN  LALT              SPC               RALT  RFNC  RMNU  RCTL              ARWL  ARWD  ARWR        NM0   NMPD        */
     126,  128,  129,              131,              135,  136,  136,  137,              159,  160,  161,        144,  145,

Insert 1 hour of useless testing, just because I added an excessive element in the array (I'm dumb asf)

[Constrat]

@seerge I think I fixed everything. I only have one question: zone 4, 5, 6, 7 are for the bottom half of the screen and should be used in the lightbar.
Bottom - Left is 5
Bottom - Left middle is half 4 half 5 (seems like)
Bottom - middle is 6
Bottom - right middle is half 6 half 7 (seems like)
Bottm - Right is half 6 half 7 again.

4 and 5 seem to be working as expected. 6 could be the ONLY middle zone but somehow it reaches all the way to the bottom far right, I don't think this is supposed to happen.

[seerge]

@Constrat yes, 0-1-2-3 are keyboard zones, 4-5-6-7 are lightbar zones

[Constrat]

Where are the screen zone defined? Zone 6 seems too big compared to the others

[Constrat]

fix with 8bcac73 (#1636)

[seerge]

@Constrat great!