fix: Ambient Mode for 17 inch keyboards #1636

Constrat · 2023-11-22T23:54:25Z

No description provided.

seerge · 2023-11-23T08:37:38Z

@Constrat great, thanks !

@Kowken can you check on your device w/o numpad if this build still looks ok ?

Constrat · 2023-11-23T08:39:40Z

I tried making it the most scalable possible, implementing both the "older" values you had and the "new" values from the .csv of my 17'' model that we used in the ORGB project 17 inch adaptation.

Kowken · 2023-11-23T10:40:54Z

@Constrat great, thanks !

@Kowken can you check on your device w/o numpad if this build still looks ok ?

GHelper.zip

Not gonna lie, it looks worse than before.

EDIT: Hold on actually, I'll send more examples because I may be mistaken

Constrat · 2023-11-23T10:42:22Z

It's a "zone" issue. We should find a way to differentiate between layout sizes (like inORGB)
Instead of the numpad you have the media row.

seerge · 2023-11-23T10:43:37Z

@Constrat or you have accidentally mixed some numbers in the change? :)

Constrat · 2023-11-23T10:44:06Z

@Constrat or you have accidentally mixed some numbers in the change? :)

I'll check (maybe I left them when I was testing the zone 6 and 7 xD).

@seerge can confirm, I'm dumb and forgot to remove the debugging zones. My bad.
Instead of this:

                    /* VDN   VUP   MICM  HPFN  ARMC  */
                         0,    0,    0,    1,    1,
        /* ESC          F0    F0    F3    F4    F5    F6    F7    F8    F9   F10   F11   F12               NULL  DEL   PAUS  PRT   HOM   */
             0,          0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,                3,   3,    3,    3,    3,
        /* BKTK    1     2     3     4     5     6     7     8     9     0     -     =   BSPC  BSPC  BSPC  PLY   NMLK  NMDV  NMTM  NMMI  */
             0,    0,    0,    0,    5,    4,    6,    7,    1,    1,    2,    2,    2,    2,    2,    2,    3,    3,    3,    3,    3,
        /* TAB     Q     W     E     R     T     Y     U     I     O     P     [     ]     \               STP   NM7   NM8   NM9   NMPL  */
             0,    0,    0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,                3,    3,    3,    3,    3,
        /* CPLK    A     S     D     F     G     H     J     K     L     ;     "     #   ENTR  ENTR  ENTR  PRV   NM4   NM5   NM6   NMPL  */
             0,    0,    0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,    2,    2,    3,    3,    3,    3,    3,
        /* LSFT  ISO\    Z     X     C     V     B     N     M     ,     .     /   RSFT  RSFT  RSFT  ARWU        NM1   NM2   NM3   NMER  */
             0,    0,    0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,    2,     2,         3,    3,    3,    3,
        /* LCTL  LFNC  LWIN  LALT              SPC               RALT  RFNC  RCTL        ARWL  ARWD  ARWR              NM0   NMPD  NMER  */
             0,    0,    0,    0,              1,                  1,    2,    2,          2,    2,    2,                3,    3,    3,
        /* LB1   LB1   LB3                                                                                             LB4   LB5   LB6   */
             5,    5,    4,                                                                                              6,    7,    7,
        /* PRT   KSTN  LOGO  LIDL  LIDR  */
             3,    3,    0,    0,    3,

It should be this:

                    /* VDN   VUP   MICM  HPFN  ARMC  */
                         0,    0,    0,    1,    1,
        /* ESC          F0    F0    F3    F4    F5    F6    F7    F8    F9   F10   F11   F12               NULL  DEL   PAUS  PRT   HOM   */
             0,          0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,                3,   3,    3,    3,    3,
        /* BKTK    1     2     3     4     5     6     7     8     9     0     -     =   BSPC  BSPC  BSPC  PLY   NMLK  NMDV  NMTM  NMMI  */
             0,    0,    0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,    2,    2,    3,    3,    3,    3,    3,
        /* TAB     Q     W     E     R     T     Y     U     I     O     P     [     ]     \               STP   NM7   NM8   NM9   NMPL  */
             0,    0,    0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,                3,    3,    3,    3,    3,
        /* CPLK    A     S     D     F     G     H     J     K     L     ;     "     #   ENTR  ENTR  ENTR  PRV   NM4   NM5   NM6   NMPL  */
             0,    0,    0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,    2,    2,    3,    3,    3,    3,    3,
        /* LSFT  ISO\    Z     X     C     V     B     N     M     ,     .     /   RSFT  RSFT  RSFT  ARWU        NM1   NM2   NM3   NMER  */
             0,    0,    0,    0,    0,    1,    1,    1,    1,    1,    2,    2,    2,    2,    2,     2,         3,    3,    3,    3,
        /* LCTL  LFNC  LWIN  LALT              SPC               RALT  RFNC  RCTL        ARWL  ARWD  ARWR              NM0   NMPD  NMER  */
             0,    0,    0,    0,              1,                  1,    2,    2,          2,    2,    2,                3,    3,    3,
        /* LB1   LB1   LB3                                                                                             LB4   LB5   LB6   */
             5,    5,    4,                                                                                              6,    7,    7,
        /* PRT   KSTN  LOGO  LIDL  LIDR  */
             3,    3,    0,    0,    3,

This will fix the wrong number row, but for the keyboard zones I don't have a lot of ideas. In a 17 inch with 4 zones and 20 columns it's a 5-width column. In a 15 inch I have no idea, seems like they have 3 less keys, so I'm guessing a 4-width would look better.

Kowken · 2023-11-23T10:48:46Z

@Constrat great, thanks !

@Kowken can you check on your device w/o numpad if this build still looks ok ?

GHelper.zip

Not gonna lie, it looks worse than before.

EDIT: Hold on actually, I'll send more examples because I may be mistaken

EDIT: Numkeys 4, 5, 6 and 7 are acting weirdly.
Also this was maybe on the previous version as well but the upper part of heatmap (fkeys and mkey, sometimes arrows) are taking a second before lighting up on this build

Constrat · 2023-11-23T10:49:20Z

Issue identified, dw. I can create a new PR. Mistake on my end.
Actually I can tweak something more.

Constrat · 2023-11-23T10:50:43Z

@Kowken what's the not lit up key? Next to the Right Shift? Is it next?
Seems like it correct?
The numkeys are already identified, I need your help for other things now.
I haven't worked on the timings for the ambient mode to take effect so this is the wrong place.
Can you remember what was the LED ID for the "NEXT" in the media keys?
Trying to guess it should either be 120 or 121.
Nvm I found your devicecontent from the ORGB discord.

Kowken · 2023-11-23T10:59:16Z

@Kowken what's the not lit up key? Next to the Right Shift? Is it next?

Seems like it correct?

Regarding ambient, all keys light up but it more a matter of how they light up, the 0.134 release made 4 zones but now there are the numkeys 4,5, 6 and 7 that lights up differently from the rest and from each other, also the skip button never lights up.

Constrat · 2023-11-23T10:59:57Z

@Kowken It's the fourth time I said this. This was identified, it was a mistake on my end. What I need now is something else xD
NEXT is 121.

Kowken · 2023-11-23T11:02:24Z

@Kowken It's the fourth time I said this. This was identified, it was a mistake on my end. What I need now is something else xD

If you are referring to both issues I mentioned (numkeys and skip) then all my apologies. The shift button look correct though, I'm sure what you are looking for.

Kowken · 2023-11-23T11:03:34Z

@Kowken what's the not lit up key? Next to the Right Shift? Is it next?

Seems like it correct?

The numkeys are already identified, I need your help for other things now.

I haven't worked on the timings for the ambient mode to take effect so this is the wrong place.

Can you remember what was the LED ID for the "NEXT" in the media keys?

Trying to guess it should either be 120 or 121.

Nvm I found your devicecontent from the ORGB discord.

Oh okay I get it now. Yeah I posted that on ORGB, do you still need something else ?

Constrat · 2023-11-23T11:04:48Z

I think I have everything.

I've removed the debug from 4, 5, 6, 7
Added the NEXT / SKIP key
Renamed a NULL (LEDID 37) which is the Delete key for 15 inches

I think this is everything.

Kowken · 2023-11-23T11:11:16Z

I think I have everything.

I've removed the debug from 4, 5, 6, 7

Added the NEXT / SKIP key

Renamed a NULL (LEDID 37) which is the Delete key for 15 inches

I think this is everything.

Okay let me know if you need something else. Have a good day.

* fix: Ambient Mode for 17 inch keyboards * fix: removed debugging keys, added "skip" for 15inch, refactor --------- Co-authored-by: Serge <5920850+seerge@users.noreply.github.com>

fix: Ambient Mode for 17 inch keyboards

b757043

seerge merged commit 8bcac73 into seerge:main Nov 23, 2023
3 checks passed

Constrat mentioned this pull request Nov 23, 2023

2022 Strix G17 - 0.134 Ambient & Heatmap issue. #1625

Closed

Constrat mentioned this pull request Nov 23, 2023

fix: ulterior fixes from #1636 #1638

Merged

Constrat mentioned this pull request Jul 16, 2024

Strix G17 (G713) < and ALT GR not lighting up in Heatmap, Ambient and Startup/Shutdown animations #2850

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Ambient Mode for 17 inch keyboards #1636

fix: Ambient Mode for 17 inch keyboards #1636

Constrat commented Nov 22, 2023

seerge commented Nov 23, 2023

Constrat commented Nov 23, 2023

Kowken commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading

seerge commented Nov 23, 2023

Constrat commented Nov 23, 2023 •

edited

Loading

Kowken commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading

Kowken commented Nov 23, 2023

Constrat commented Nov 23, 2023 •

edited

Loading

Kowken commented Nov 23, 2023

Kowken commented Nov 23, 2023

Constrat commented Nov 23, 2023

Kowken commented Nov 23, 2023

fix: Ambient Mode for 17 inch keyboards #1636

fix: Ambient Mode for 17 inch keyboards #1636

Conversation

Constrat commented Nov 22, 2023

seerge commented Nov 23, 2023

Constrat commented Nov 23, 2023

Kowken commented Nov 23, 2023 • edited Loading

Constrat commented Nov 23, 2023 • edited Loading

seerge commented Nov 23, 2023

Constrat commented Nov 23, 2023 • edited Loading

Kowken commented Nov 23, 2023 • edited Loading

Constrat commented Nov 23, 2023 • edited Loading

Constrat commented Nov 23, 2023 • edited Loading

Kowken commented Nov 23, 2023

Constrat commented Nov 23, 2023 • edited Loading

Kowken commented Nov 23, 2023

Kowken commented Nov 23, 2023

Constrat commented Nov 23, 2023

Kowken commented Nov 23, 2023

Kowken commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading

Kowken commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading

Constrat commented Nov 23, 2023 •

edited

Loading