Change segmentio to 'Destination' type #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7cd4a09 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
reviewed
Dec 1, 2023
| @@ -125,7 +125,7 @@ export function segmentio( | |||
|
|
|||
| const segmentio: Plugin = { | |||
| name: 'Segment.io', | |||
| type: 'after', | |||
| type: 'destination', | |||
There was a problem hiding this comment.
This means destinations (or failures) should no longer block segment! Are there any browser tests we can add to assert this behavior (I don't really care about node)?
silesky
reviewed
Jan 10, 2024
| }, | ||
| } | ||
| ), | ||
| sleep(100), |
There was a problem hiding this comment.
Never seen this way of setting a timeout, neat.
silesky
approved these changes
Jan 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the segment.io plugin to 'Destination' type, to prevent any issues with other plugins impacting event delivery to Segment
Tested via confirming sending events works as expected
yarn changeset. Read about changesets here).