fix: fixes buffering for legacy destinations #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37282e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
approved these changes
Apr 12, 2024
chrisradek
approved these changes
Apr 12, 2024
silesky
reviewed
Apr 12, 2024
| @@ -192,7 +192,7 @@ export class LegacyDestination implements InternalPluginWithAddMiddleware { | |||
| return ( | |||
| // page events can't be buffered because of destinations that automatically add page views | |||
| ctx.event.type !== 'page' && | |||
| (isOffline() || this._ready === false || this._initialized === false) | |||
| (isOffline() || this._ready !== true || this._initialized !== true) | |||
There was a problem hiding this comment.
Nit: Couldn't we just get rid of the explicit false and do if (!this.ready) etc?
Just looks a bit weird in JS -- It'd make me think _ready could be an object or a string or whatever. 😄
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Classic Destinations buffering to properly buffer events while not loaded
Fixed
shouldBuffercheck as the starting state changed fromfalsetoundefinedfor ready/initialized. Hence events were bypassing buffer all the time.Changed the behaviour of
scheduleFlushas previously it was being called after the timeout and ignoring if the plugin had finished initializing. The retry would work properly if the plugin throws an error but Bing/FB don't hence it was marking those events as sent.onReadyandonInitializedinstead of retrying at intervals.I've included a changeset (psst. run
yarn changeset. Read about changesets here).