Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not make plugin.version mandatory #1128

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Aug 19, 2024

There's no reason to force specifying a version -- it's only used for metrics, and typically for action destinations. It's just extra boilerplate.

Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: ba16b82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@segment/analytics-core Minor
@segment/analytics-next Minor
@segment/analytics-node Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky changed the title Do not make version mandatory Do not make plugin.version mandatory Aug 19, 2024
@silesky silesky merged commit c45d445 into master Sep 25, 2024
5 checks passed
@silesky silesky deleted the do-not-make-version-mandatory branch September 25, 2024 15:48
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants