Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typings instructions from snippet users and export Snippet type #541

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Jul 15, 2022

In the immediate future, we may want to also publish a package that just contains AnalyticsSnippet (and other, related types) — or update the segment-analytics package (and attempt to become maintainers of it) on DefinitelyTyped. This is fine for now.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2022

🦋 Changeset detected

Latest commit: 3a7981a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky closed this Jul 15, 2022
@silesky silesky reopened this Jul 15, 2022
@silesky silesky requested a review from zikaari July 15, 2022 20:50
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing 🔥🔥🔥

@silesky silesky merged commit 2e0a91c into master Jul 15, 2022
@silesky silesky deleted the add-typings-instructions branch July 15, 2022 21:00
@github-actions github-actions bot mentioned this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants