Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ambient import conflict #621

Merged
merged 2 commits into from
Oct 9, 2022
Merged

fix ambient import conflict #621

merged 2 commits into from
Oct 9, 2022

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Oct 9, 2022

It occurred to me as I was walking my dog that by using an ambient interface of AnalyticsStandalone locally, we would end up clobbering consumer global declarations since these ambient declarations cross module boundaries. Sure enough:

image

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2022

🦋 Changeset detected

Latest commit: 8cde3a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky merged commit 5026ee1 into master Oct 9, 2022
@silesky silesky deleted the fix-ambient-import-conflict branch October 9, 2022 14:11
@github-actions github-actions bot mentioned this pull request Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant