Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that occurs when explicitly enabling/disabling action destinations.
A very small handful of action destinations have a different plugin name than their creation name. Amplitude is one of these.
Our current remote loader implementation only takes into account the plugin's name and not the creation name when deciding whether to load the destination.
That means there are 2 scenarios where loading Amplitude would not do the expected thing.
analytics.load(writeKey, { integrations: { All: false, "Actions Amplitude": true }})
With this scenario, all destinations are disabled by default and only if one is explicitly enabled will it be loaded. In this specific example, the plugin name is
Amplitude (Actions)
despite the integration (creationName) beingActions Amplitude
. This mismatch caused the plugin to fail to load.analytics.load(writeKey, { integrations: { "Actions Amplitude": false }})
With this scenario, the destination is explicitly disabled. However without these changes users would have had to specify
Amplitude (Actions)
instead.[x] I've included a changeset (psst. run
yarn changeset
. Read about changesets here).