Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests faster / less flaky #713

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Make tests faster / less flaky #713

merged 3 commits into from
Dec 7, 2022

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Dec 6, 2022 •
edited
Loading

This doesn't make everything offline, but this PR was getting large.

  • Gets rid of some ugly errors in the console
  • Browser tests run 30% faster
  • make fetch settings offline
  • CDNSettings are a fixture, which makes them easy to reason about and update. It's typed, so any updates can give us contract reassurance
  • Improve incomplete LegacySettings types

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 5b11626

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky changed the title Make tests a bit less flaky Make tests faster / less flaky Dec 6, 2022
@silesky silesky force-pushed the broken-integration-tests branch 2 times, most recently from 3364e56 to b8d9b8f Compare December 6, 2022 23:48
@silesky silesky requested a review from a team December 7, 2022 03:36
@silesky silesky merged commit 0d70637 into master Dec 7, 2022
@silesky silesky deleted the broken-integration-tests branch December 7, 2022 19:37
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljackins danieljackins danieljackins approved these changes

@zikaari zikaari Awaiting requested review from zikaari

@chrisradek chrisradek Awaiting requested review from chrisradek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silesky @danieljackins