Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webdriver.io interception issue (#742) by choosing fetch function at call time rather than import time #742

Merged
merged 6 commits into from
Jan 3, 2023

Conversation

silesky
Copy link
Contributor

@silesky silesky commented Dec 29, 2022

Fixes #739

Continuation of #740 by @ksubramanian2

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

🦋 Changeset detected

Latest commit: 2b57cb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@silesky silesky requested review from pooyaj and a team December 29, 2022 18:40
@silesky silesky changed the title fix: fetch-dispatcher to set fetch within dispatch Fix webdriver.io interception issue by getting fetch function at call time rather than import time Dec 29, 2022
@silesky silesky changed the title Fix webdriver.io interception issue by getting fetch function at call time rather than import time Fix webdriver.io interception issue (#742) by choosing fetch function at call time rather than import time Dec 29, 2022
@silesky silesky force-pushed the dispatchfetch branch 2 times, most recently from a8a992b to d42675a Compare December 30, 2022 18:04
@silesky silesky force-pushed the dispatchfetch branch 3 times, most recently from cdb8343 to 6feb537 Compare December 31, 2022 22:51
@silesky silesky self-assigned this Jan 3, 2023
@silesky silesky merged commit e29a21a into master Jan 3, 2023
@silesky silesky deleted the dispatchfetch branch January 3, 2023 20:06
@github-actions github-actions bot mentioned this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebdriverIO tests
2 participants