-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ID Validation Error Message / refactor #835
Conversation
🦋 Changeset detectedLatest commit: 42ed459 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes #834 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! love the bundle size savings 📉
This should not have any behavior change.
I'm keeping the string requirement to be consistent with mobile SDK: I think it's better to force users to coerce IDs to string on their end, rather than have them surprised when their IDs are coerced for them. However, it's important to improve the error message.
Anyone upgrading from analytics-node who is now facing more strict ID validation will continue to get a validation error, but that error won't be misleading.
https://segment.atlassian.net/browse/LIBWEB-1377