-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move context augmentation to Page enrichment #939
Conversation
🦋 Changeset detectedLatest commit: 4614b24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c98fd6e
to
135e1fb
Compare
@zikaari This PR is a big improvement architecturally! Thanks for taking this on.
Cool! Yeah, I see this plugin is about augmenting the event with information from the user's environment-- so maybe EnvironmentAugmentation plugin would be a good candidate -- but "page" can also be interpreted as a kind of word for environment :-) I mainly don't like the word 'enrichment' because this plugin isn't a type:enrichment plugin -- so it's v confusing. |
@pooyaj Do you know any dangers of renaming a plugin on top of your head? Not just the symbol name, but also If you don't feel confident, we can leave renaming it to some other time. |
@zikaari change to core package (campaign interface) should have a another changeset 😉 |
Part of https://segment.atlassian.net/browse/LIBWEB-1426
Since Page Enrichment is no longer just enriching "page" events, with page information, I wanted to rename this to something generic like "Context Enrichment", but wasn't certain if this is safe. Open to discussion.
The original implementation suggests something about falling back to "options" if "context" is not there. Not sure what that means, so please help me identify what's the intended outcome of that design so I can double-check that behaviour is not impacted.