fix: handle null as the first argument in identify #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 121a317 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
silesky
requested review from
chrisradek,
danieljackins,
pooyaj and
silesky
silesky
reviewed
Sep 14, 2023
| options?: Options | ||
| callback?: Callback | ||
| } = {} | ||
| // It's a stack so it's reversed so that we go through each of the expected arguments |
There was a problem hiding this comment.
Is this a leetcode problem 😁
chrisradek
approved these changes
Sep 14, 2023
silesky
reviewed
Sep 16, 2023
packages/browser/src/core/arguments-resolver/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
silesky
reviewed
Sep 16, 2023
packages/browser/src/core/arguments-resolver/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
silesky
reviewed
Sep 29, 2023
| callback?: Callback | ||
| } = {} | ||
| // It's a stack so it's reversed so that we go through each of the expected arguments | ||
| const orderStack: Array<keyof typeof values> = [ |
There was a problem hiding this comment.
Using the old TS array syntax???
There was a problem hiding this comment.
For some reason eslint didn't like the new syntax :(
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn changeset. Read about changesets here).