Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on-slide and document attributes #6

Merged
merged 2 commits into from
Feb 25, 2016
Merged

Conversation

knownasilya
Copy link
Collaborator

Basically {{#carousel-container on-slide=(action 'slideChanged')}} where the action would look like this:

slideChanged(options) {
  console.log(options);
  // => { index: 1, previousIndex: 0, direction: 'right' }
}

@selvagsz
Copy link
Owner

@knownasilya welcome addition 👍

Question
I have the practice of using hyphenated actions for the components like on-save, on-cancel. What do you prefer on-slide or onslide ?

@knownasilya
Copy link
Collaborator Author

We can use the - for consistency since the other attribute has one.

@knownasilya knownasilya changed the title Add onslide and document attributes Add on-slide and document attributes Feb 25, 2016
selvagsz pushed a commit that referenced this pull request Feb 25, 2016
Add `on-slide` and document attributes
@selvagsz selvagsz merged commit c1e7e0e into selvagsz:master Feb 25, 2016
@selvagsz
Copy link
Owner

@knownasilya Thanks!

@knownasilya knownasilya deleted the action branch February 25, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants