Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to configure extra manifests through values.yaml #1278

Merged
merged 1 commit into from
May 23, 2024

Conversation

karol-szymanowski
Copy link
Contributor

@karol-szymanowski karol-szymanowski commented May 22, 2024

This change allows users to deploy additional kubernetes manifests within this chart.

Why?

By adding additional objects (like external-secret) I can mount secrets on which this app depends on, very useful when chart is deployed through tools like ArgoCD. It's generic enough that it will find many more use cases.

I was inspired by this thread: argoproj/argo-helm#1094

@karol-szymanowski karol-szymanowski changed the title feat: allow to configure extra manifest through values feat: allow to configure extra manifests through value.yaml May 22, 2024
@karol-szymanowski karol-szymanowski changed the title feat: allow to configure extra manifests through value.yaml feat: allow to configure extra manifests through values.yaml May 22, 2024
@Mokto
Copy link
Contributor

Mokto commented May 23, 2024

I'm not sure I like the added complexity.

In my opinion it's better to create a new chart that has the sentry dependency where you can add as many manifests as you want.

@karol-szymanowski
Copy link
Contributor Author

karol-szymanowski commented May 23, 2024

I think the cost of adding this change is very low and it makes the chart much more flexible for different setups. In some cases creating separate helm chart means that you need to configure the whole CI/CD just to add one resource.

It's especially helpful when you use gitops and tools like ArgoCD, if I had to configure my own chart I would lose the ability to autoupdate the chart in argo. Instead I'd need some additional tools that would update helm dependencies or rely on some hacky solution.

From my experience pretty much every major helm chart let users to expand charts like that, examples:

I don't say that this is the best practise but I think it became sort of a standard and not having it might put some people in uncomfortable spot. As I said, from the maintainer POV the cost of adding it should be minimal and it can reduce a lot of complexity on a user side.

@Mokto
Copy link
Contributor

Mokto commented May 23, 2024

I'm still not fund of the idea but you're right, it doesn't bring that much complexity!

@Mokto Mokto merged commit 3fec182 into sentry-kubernetes:develop May 23, 2024
2 checks passed
@Mokto Mokto mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants