Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes on gRPC 1.27.0 #10

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Breaking changes on gRPC 1.27.0 #10

merged 2 commits into from
Feb 4, 2020

Conversation

matang28
Copy link
Contributor

@matang28 matang28 commented Feb 2, 2020

When updating to gRPC 1.27 there are breaking changes on gRPC resolver package (mainly naming changes).

And I've added a go.mod file, so if you accept this one you'll need to change the module definition to yours.

Currently we are working with this version on PROD and everything seems to work fine.

@matang28 matang28 requested a review from sercand February 2, 2020 12:23
@sercand
Copy link
Owner

sercand commented Feb 2, 2020

Thanks for the MR.
I will be merging it tomorrow.

@sercand sercand merged commit 3a5800a into sercand:master Feb 4, 2020
@luthfikw
Copy link

luthfikw commented Feb 5, 2020

@sercand when it will released?

@sercand
Copy link
Owner

sercand commented Feb 5, 2020

@luthfikw I have already tagged v2.4.0.

@luthfikw
Copy link

luthfikw commented Feb 5, 2020

cool thank you @sercand @matang28

@matang28
Copy link
Contributor Author

matang28 commented Feb 5, 2020

Following this issue #11

@sercand I think that we have a problem here, maybe related to the fact that kuberesolver major version is greater than v1, according to go.mod rules:
If an old package and a new package have the same import path, the new package must be backwards compatible with the old package.
(https://research.swtch.com/vgo-import, https://blog.golang.org/v2-go-modules)

Then your module path should be v2 (and the one used by others).

@sercand
Copy link
Owner

sercand commented Feb 5, 2020

@matang28 I have released v2 of the package before go.mod finalized. Therefore, I just removed go.mod as a quick hack.

@matang28
Copy link
Contributor Author

matang28 commented Feb 5, 2020

@sercand cool, I can verify that v2.4.0+incompatible (latest) works for me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants