Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap Vec<T> for Cow<[T]> in CreateActionRow::Buttons #2985

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Swap Vec<T> for Cow<[T]> in CreateActionRow::Buttons #2985

merged 1 commit into from
Oct 7, 2024

Conversation

GnomedDev
Copy link
Member

Closes #2984.

@github-actions github-actions bot added the builder Related to the `builder` module. label Oct 7, 2024
@arqunis arqunis added enhancement An improvement to Serenity. breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users labels Oct 7, 2024
@arqunis arqunis merged commit c88004c into serenity-rs:next Oct 7, 2024
21 checks passed
@GnomedDev GnomedDev deleted the actionrow-buttons-cow branch October 7, 2024 22:14
GnomedDev added a commit to GnomedDev/serenity that referenced this pull request Oct 7, 2024
@GnomedDev
Swap Vec<T> for Cow<[T]> in CreateActionRow::Buttons (serenity-…
7f04f87 
…rs#2985)

Closes serenity-rs#2984.
GnomedDev added a commit that referenced this pull request Oct 7, 2024
@GnomedDev
Swap Vec<T> for Cow<[T]> in CreateActionRow::Buttons (#2985)
6764370 
Closes #2984.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
breaking change The public API is changed, resulting in miscompilations or unexpected new behaviour for users builder Related to the `builder` module. enhancement An improvement to Serenity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GnomedDev @arqunis